Skip to content

Fix inconsistency in grid definition#929

Merged
kzscisoft merged 1 commit intodevfrom
kzscisoft/grid-metric-consistency
Mar 3, 2026
Merged

Fix inconsistency in grid definition#929
kzscisoft merged 1 commit intodevfrom
kzscisoft/grid-metric-consistency

Conversation

@kzscisoft
Copy link
Collaborator

Fix ordering when creating automatic

Issue: #921

Python Version(s) Tested: 3.13

Operating System(s): Ubuntu 25.10

📝 Summary

Auto-grids were created with the wrong axis ordering.

🔍 Diagnosis

Found when logging a grid metric without providing a grid upfront:

run.log_metrics({"test": numpy.ones((20, 30))})

🔄 Changes

Simple reversal reversed(array.shape) when using array shape for axes intervals.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft merged commit 32d6dbe into dev Mar 3, 2026
16 of 17 checks passed
@kzscisoft kzscisoft deleted the kzscisoft/grid-metric-consistency branch March 3, 2026 11:46
@kzscisoft kzscisoft linked an issue Mar 3, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default grid creation makes grid wrong way round

1 participant